Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cache): detect malformed data read from storage #2161

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

zsilbi
Copy link
Contributor

@zsilbi zsilbi commented Feb 22, 2024

πŸ”— Linked issue

#2160

Not fixes the issue itself, but prevents any related crashes.

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Added a check for the cache to validate that the data read from storage is an object.
It prevents crashing the application when the read data is somehow got malformed.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 merged commit 955873b into nitrojs:main Feb 27, 2024
4 checks passed
@pi0
Copy link
Member

pi0 commented Feb 27, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants