fix(openapi): openapi.json ignores custom port #2251
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#2215
β Type of change
π Description
Currently, weβre using a hard coded string (
http://localhost:3000
) for the base url that is added to theopenapi.json
. If a custom port is configured, itβs just ignored. This PR fixes it by using the same logic that is used in other places:process.env.NITRO_PORT
, if itβs not available:process.env.PORT
, if itβs not available:While I was on it, Iβve also removed the trailing slash from the base URL. Itβs not really needed, as all routes start with a
/
already, but it looks cleaner. β¨π Checklist