Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude internal /_*, /api/_* routes from NitroFetchReqeust type #232

Merged

Conversation

didavid61202
Copy link
Contributor

πŸ”— Linked issue

fix #231

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

type NitroFetchRequest should exclude all /_* and /api/_* routes as they are for internal use and should not show type hints/auto-complete to end users.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Co-authored-by: pooya parsa <pyapar@gmail.com>
@didavid61202 didavid61202 requested a review from pi0 May 12, 2022 16:38
@pi0 pi0 merged commit 00aa131 into nitrojs:main May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: exclude all /_* and /api/_* routes from NitroFetchRequest type
2 participants