Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azure): correctly handle maxAge cookie option #2403

Merged
merged 3 commits into from
Apr 30, 2024
Merged

fix(azure): correctly handle maxAge cookie option #2403

merged 3 commits into from
Apr 30, 2024

Conversation

julien1619
Copy link
Contributor

πŸ”— Linked issue

#2399

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

In the utils that sets cookies for Azure, it is lowercasing the cookie keys at line 24, so Max-Age becomes max-age:

const setCookieOptions = Object.fromEntries(
_setCookieOptions.map(([k, v]) => [k.toLowerCase(), v])
);

But uses another undefined key a few lines later:

maxAge: parseNumber(setCookieOptions.maxAge),

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@julien1619 julien1619 changed the title Patch 1 fix(azure): correctly handle maxAge cookie option Apr 30, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (if you later find a way to add tests that would be awesome to avoid regression)

@pi0 pi0 merged commit aabdc9c into nitrojs:main Apr 30, 2024
4 checks passed
@julien1619 julien1619 deleted the patch-1 branch April 30, 2024 08:42
@pi0 pi0 mentioned this pull request Jun 13, 2024
@pi0 pi0 mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants