Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: always use native fetch in builds #2527

Merged
merged 1 commit into from
Jun 13, 2024
Merged

refactor!: always use native fetch in builds #2527

merged 1 commit into from
Jun 13, 2024

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jun 13, 2024 •
edited
Loading

this PR drops nodeFetchCompat flag, always defaulting node-fetch-native to the platform fetch and disable from build since Node 16 is not supported anymore.

Escape hatch: Using alias config, node-fetch-native can still be overriden

@pi0 pi0 self-assigned this Jun 13, 2024
@pi0 pi0 changed the title refactor(core)!: remove deprecated exports refactor!: always use native fetch in builds Jun 13, 2024
@pi0 pi0 merged commit 3253d31 into main Jun 13, 2024
5 checks passed
@pi0 pi0 deleted the chore/node-fetch-compat branch June 13, 2024 22:36
@pi0 pi0 mentioned this pull request Jun 13, 2024
Draft
16 tasks
davidstackio pushed a commit to davidstackio/nitro that referenced this pull request Aug 7, 2024
@pi0 @davidstackio
refactor!: always use native fetch in builds (nitrojs#2527)
681c29e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pi0 pi0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pi0