Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upate cli preset with esm module format #2539

Merged
merged 4 commits into from
Jun 17, 2024
Merged

fix: upate cli preset with esm module format #2539

merged 4 commits into from
Jun 17, 2024

Conversation

jrutila
Copy link
Contributor

@jrutila jrutila commented Jun 17, 2024

🔗 Linked issue

Part of implementing #2466

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The generated server/index.mjs is no longer dependent on the require.

Also, it uses Object.entries for result headers.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title fix: preset cli works with ES module fix: upate cli preset with esm module format Jun 17, 2024
pi0
pi0 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0
Copy link
Member

pi0 commented Jun 17, 2024

can you please check ts issue?

@pi0 pi0 merged commit f6f2327 into nitrojs:v2 Jun 17, 2024
3 of 4 checks passed
pi0 pushed a commit that referenced this pull request Jun 27, 2024
@jrutila @pi0
fix: update cli preset with esm module format (#2539)
a5aa705
@pi0 pi0 mentioned this pull request Jun 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrutila @pi0