-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add genezio preset #2637
feat: add genezio preset #2637
Conversation
* Added genezio preset * Auto-generate genezio file * Enable custom names and default region for yaml file * Create genezio.yaml * Basic draft of genezio.md file * Update genezio.md * Update for the auto-generation of the yaml files * Update index.ts * Update genezio.md * Update genezio.md * Update genezio.md * Update genezio.md * Update genezio.md * Update genezio.md Co-authored-by: Andreia OcΔnoaia <andreia.ocanoaia@gmail.com> * Update genezio.md * Update genezio.md * Update genezio.md * Reverted the accidental changes to _all.gen * Reverted the playground changes * Update genezio.md --------- Co-authored-by: Andreia OcΔnoaia <andreia.ocanoaia@gmail.com>
Hey @pi0, I've tested this feature and it's ready for a code review. Feel free to add yourself as a reviewer anytime. |
src/presets/genezio/preset.ts
Outdated
}, | ||
{ | ||
name: "genezio" as const, | ||
stdName: "genezio", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stdName needs to be recognized with unjs/std-env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(removed for now)
src/presets/genezio/utils.ts
Outdated
const name = await getNameFromPackage(); | ||
const initialPath = dirname(nitro.options.output.dir); | ||
const genezioConfigPath = resolve(initialPath, "genezio.yaml"); | ||
const genezioConfigContent = ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally zero config nitro presets use a special "output directory" that is supported by deployment providers instead of writing to project root (which is version controlled)
If manual file is required, we should keep it as docs only (i would be happy to explain this more if you like to integrate zero deploy with your platform)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(moved to the docs for now)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR β€οΈ Merging it to be able to do e2e test via nightly release channel. For next steps, it would be amazing if you can join our discord channel (shared invitation in X)
π Linked issue
β Type of change
π Description
Genezio
is a Function-as-a-Service (FaaS) platform designed to deploy serverless applications efficiently, minimizing both costs and cold start times.I have introduced a new preset named
--genezio
. This preset provides users with additional configuration options, allowing for more flexibility and customization.Additionally, I have updated the documentation to reflect these changes, ensuring that users can easily understand and utilize the new preset.
π Checklist