Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(firebase): support 22 for nodeVersion #2653

Merged
merged 4 commits into from
Aug 22, 2024
Merged

types(firebase): support 22 for nodeVersion #2653

merged 4 commits into from
Aug 22, 2024

Conversation

luc122c
Copy link
Contributor

@luc122c luc122c commented Aug 12, 2024

🔗 Linked issue

N/A

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Google Cloud have added preview support for Node 22. This PR makes Nitro aware that 22 is a valid option now.

See: https://cloud.google.com/functions/docs/runtime-support#node.js

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@luc122c luc122c changed the base branch from v2 to main August 12, 2024 23:06
@luc122c luc122c marked this pull request as ready for review August 12, 2024 23:10
@luc122c luc122c changed the base branch from main to v2 August 12, 2024 23:18
@pi0 pi0 changed the title chore(firebase): add nodejs22 runtime type feat(firebase): add support 22 runtime Aug 22, 2024
@pi0 pi0 changed the title feat(firebase): add support 22 runtime type(firebase): support 22 for nodeVersion Aug 22, 2024
@pi0 pi0 changed the title type(firebase): support 22 for nodeVersion types(firebase): support 22 for nodeVersion Aug 22, 2024
pi0
pi0 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnx!

@pi0 pi0 merged commit 0859c82 into nitrojs:v2 Aug 22, 2024
4 checks passed
@luc122c luc122c deleted the fix/add-node-22 branch August 22, 2024 22:08
luc122c added a commit to luc122c/unjs-nitro that referenced this pull request Aug 24, 2024
@luc122c
types(firebase): support 22 for nodeVersion (nitrojs#2653)
94a3cda
@pi0 pi0 mentioned this pull request Oct 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luc122c @pi0