Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cache): try decode path #2658

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix(cache): try decode path #2658

merged 1 commit into from
Oct 31, 2024

Conversation

cjpearson
Copy link
Contributor

πŸ”— Linked issue

#2657

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This follows the same approach as #1459, replacing the decodeURI with decodePath from ufo. This means that an invalid path will no longer throw an error but instead use the undecoded text.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

src/runtime/internal/cache.ts Outdated Show resolved Hide resolved
@pi0 pi0 changed the title fix(cache): safe decode path fix(cache): try decode path Aug 13, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit dc42f89 into nitrojs:v2 Oct 31, 2024
4 checks passed
@pi0 pi0 mentioned this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants