Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add zerops preset #2698

Merged
merged 12 commits into from
Sep 5, 2024
Merged

feat: add zerops preset #2698

merged 12 commits into from
Sep 5, 2024

Conversation

nermalcat69
Copy link
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@nermalcat69 nermalcat69 marked this pull request as draft August 30, 2024 01:38
@nermalcat69 nermalcat69 marked this pull request as ready for review August 30, 2024 15:38
@nermalcat69 nermalcat69 changed the title feat: zerops guide + preset feat: zerops guide & preset Aug 30, 2024
@nermalcat69
Copy link
Contributor Author

can someone review this ?

@pi0 pi0 changed the title feat: zerops guide & preset feat: add zerops preset Sep 5, 2024
pi0
pi0 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I have made few improvements to the docs feel free to make PR to ammend.

@pi0 pi0 merged commit 661002c into nitrojs:v2 Sep 5, 2024
4 checks passed
@pi0 pi0 mentioned this pull request Oct 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nermalcat69 @pi0