Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev-server): redirect requsts without base url #2713

Merged
merged 4 commits into from
Sep 5, 2024
Merged

feat(dev-server): redirect requsts without base url #2713

merged 4 commits into from
Sep 5, 2024

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/cli#469

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This is a quality-of-life improvement rather than a bugfix per se.

If a baseURL is provided, this means that we can redirect user to it if they access a different URL.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Sep 5, 2024
@danielroe danielroe requested a review from pi0 September 5, 2024 14:40
@danielroe danielroe self-assigned this Sep 5, 2024
@pi0 pi0 changed the title fix(dev-server): redirect to baseURL feat(dev-server): redirect requsts without base url Sep 5, 2024
src/core/dev-server/server.ts Outdated Show resolved Hide resolved
src/core/dev-server/server.ts Outdated Show resolved Hide resolved
@pi0 pi0 merged commit ba87525 into v2 Sep 5, 2024
5 checks passed
@pi0 pi0 deleted the fix/dev-server branch September 5, 2024 15:08
@pi0 pi0 mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find any route matching /. after setting app.baseURL to '/somepath/'
2 participants