-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(firebase): validate custom serverFunctionName
#2773
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Oct 3, 2024
pi0
reviewed
Oct 3, 2024
jpsc
force-pushed
the
fix/firebase-preset
branch
from
October 4, 2024 10:52
6f7afae
to
ba10918
Compare
Not sure how to properly validade this fix. |
jpsc
force-pushed
the
fix/firebase-preset
branch
from
October 4, 2024 10:55
ba10918
to
be91ea5
Compare
jpsc
changed the title
fix(firebase): normalize serverFunctionName
fix(firebase): validate serverFunctionName
Oct 4, 2024
pi0
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
pi0
changed the title
fix(firebase): validate serverFunctionName
fix(firebase): validate custom Oct 8, 2024
serverFunctionName
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Resolves #2643
β Type of change
π Description
Normalize
serverFunctionName
to using underscore (_
) instead of dashes (-
).Resolves #2643
π Checklist