Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cache): catch error when getting cache entry (#2609) #2820

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

cjpearson
Copy link
Contributor

πŸ”— Linked issue

#2609

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This change catches possible errors on getting the cache item, following the same pattern used on setting cache items. With this change, an error when reading the cache (e.g. redis disconnect) will not cause the request to fail but will instead execute the cached function.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@cjpearson cjpearson requested a review from pi0 as a code owner October 29, 2024 20:56
@pi0 pi0 added the cache label Oct 30, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit ee922d7 into nitrojs:v2 Oct 31, 2024
4 checks passed
@pi0 pi0 mentioned this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants