Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose router in NitroApp #302

Merged
merged 1 commit into from
Jun 20, 2022
Merged

feat: expose router in NitroApp #302

merged 1 commit into from
Jun 20, 2022

Conversation

danielroe
Copy link
Member

🔗 Linked issue

nuxt/nuxt#14177

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Exposing the router allows registering additional routes to be handled by the default router (rather than calling app.use which will append to the bottom of the stack.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the enhancement New feature or request label Jun 20, 2022
@danielroe danielroe requested a review from pi0 June 20, 2022 11:39
@danielroe danielroe self-assigned this Jun 20, 2022
@pi0 pi0 merged commit ef5e7f1 into main Jun 20, 2022
@pi0 pi0 deleted the feat/router-in-app branch June 20, 2022 11:50
@danielroe danielroe mentioned this pull request Oct 9, 2022
Closed
WinterYukky pushed a commit to WinterYukky/nitro that referenced this pull request Nov 1, 2022
@danielroe @WinterYukky
feat: expose router in NitroApp (nitrojs#302)
bb016c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 Awaiting requested review from pi0

Assignees

@danielroe danielroe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0