Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support prerendering binary files #320

Merged
merged 9 commits into from
Aug 24, 2022
Merged

feat: support prerendering binary files #320

merged 9 commits into from
Aug 24, 2022

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jun 29, 2022

πŸ”— Linked issue

#319

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This supports writing prerendered responses as binary data directly.

To resolve #319 fully, we also need to support returning binary data in unenv rather than always coercing it to a string. (unjs/unenv#43).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the enhancement New feature or request label Jun 29, 2022
@danielroe danielroe requested a review from pi0 June 29, 2022 11:28
@danielroe danielroe self-assigned this Jun 29, 2022
@danielroe danielroe marked this pull request as draft June 29, 2022 13:06
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #320 (44cf13f) into main (cc8527a) will decrease coverage by 0.04%.
The diff coverage is 60.00%.

❗ Current head 44cf13f differs from pull request most recent head b2635ce. Consider uploading reports for the commit b2635ce to get more accurate results

@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
- Coverage   53.57%   53.53%   -0.05%     
==========================================
  Files          54       54              
  Lines        3494     3495       +1     
  Branches      368      369       +1     
==========================================
- Hits         1872     1871       -1     
- Misses       1267     1268       +1     
- Partials      355      356       +1     
Impacted Files Coverage Ξ”
src/types/nitro.ts 100.00% <ΓΈ> (ΓΈ)
src/utils/index.ts 22.22% <0.00%> (-1.31%) ⬇️
src/prerender.ts 67.56% <100.00%> (+0.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit d1d1015 into main Aug 24, 2022
@pi0 pi0 deleted the feat/binary-prerender branch August 24, 2022 23:03
@pi0 pi0 mentioned this pull request Aug 26, 2022
WinterYukky pushed a commit to WinterYukky/nitro that referenced this pull request Nov 1, 2022
Co-authored-by: Pooya Parsa <pooya@pi0.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support for prerendering binary files
2 participants