Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: call rollup:before before generating rollup config #335

Merged
merged 1 commit into from
Jul 12, 2022
Merged

fix: call rollup:before before generating rollup config #335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ export async function copyPublicAssets (nitro: Nitro) {
}

export async function build (nitro: Nitro) {
const rollupConfig = getRollupConfig(nitro)
await nitro.hooks.callHook('rollup:before', nitro)
const rollupConfig = getRollupConfig(nitro)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think put hook before to allow extending resolved config but not possible. We can use new hook for that :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

return nitro.options.dev ? _watch(nitro, rollupConfig) : _build(nitro, rollupConfig)
}

Expand Down