Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: utilize knitwork to generate safe variable names #447

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

TheAlexLichter
Copy link
Member

@TheAlexLichter TheAlexLichter commented Aug 29, 2022

πŸ”— Linked issue

unjs/scule#6

❓ Type of change

  • πŸ‘Œ Enhancement (improving an existing functionality like performance)

πŸ“š Description

Use https://github.com/unjs/knitwork to generator and/or serialize imports

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@TheAlexLichter TheAlexLichter marked this pull request as ready for review August 29, 2022 20:41
@pi0 pi0 changed the title refactor: utilize knitwork refactor: utilize knitwork to generate safe variable names Aug 31, 2022
@pi0 pi0 merged commit 7ca0904 into nitrojs:main Aug 31, 2022
@pi0
Copy link
Member

pi0 commented Aug 31, 2022

Thanks!

@TheAlexLichter TheAlexLichter deleted the refactor/knitwork branch August 31, 2022 15:08
WinterYukky pushed a commit to WinterYukky/nitro that referenced this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants