Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issues with firebase dependencies #48

Merged
merged 4 commits into from
Apr 7, 2022
Merged

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Apr 7, 2022

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This fixes firebase dependency collection. Note: this still needs to be improved but we are working within the limits of firebase, which is that it doesn't upload our beautifully trace node_modules but insists on rerunning an npm install in the cloud.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Apr 7, 2022
@danielroe danielroe requested a review from pi0 April 7, 2022 20:56
@danielroe danielroe self-assigned this Apr 7, 2022
@pi0
Copy link
Member

pi0 commented Apr 7, 2022

Sorry for late merge!

@pi0 pi0 merged commit 3498d7d into main Apr 7, 2022
@pi0 pi0 deleted the fix/firebase-package-json branch April 7, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants