Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fully resolve internal paths for autoimports #543

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Currently, generated auto-imports are relative to #internal/nitro which means they have no type safety unless typescript.internalPaths is set. This PR resolves them so we don't need to expose access to #internal/nitro.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Oct 4, 2022
@danielroe danielroe requested a review from pi0 October 4, 2022 11:37
@danielroe danielroe self-assigned this Oct 4, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #543 (f9f09ad) into main (2049def) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
+ Coverage   63.96%   64.08%   +0.11%     
==========================================
  Files          55       55              
  Lines        3644     3653       +9     
  Branches      400      403       +3     
==========================================
+ Hits         2331     2341      +10     
+ Misses       1299     1298       -1     
  Partials       14       14              
Impacted Files Coverage Ξ”
src/build.ts 54.54% <100.00%> (+1.91%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danielroe danielroe merged commit 4ce9d82 into main Oct 10, 2022
@danielroe danielroe deleted the fix/auto-import-types branch October 10, 2022 10:21
WinterYukky pushed a commit to WinterYukky/nitro that referenced this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants