-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(externals): keep both version of conflicting dependencies #758
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
Any feedback to this PR @pi0? |
Codecov Report
@@ Coverage Diff @@
## main #758 +/- ##
==========================================
+ Coverage 70.07% 70.37% +0.30%
==========================================
Files 57 57
Lines 5229 5377 +148
Branches 575 600 +25
==========================================
+ Hits 3664 3784 +120
- Misses 1556 1584 +28
Partials 9 9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Thanks legendary @mahdiboomeri for this implementation π― During the local review, I found that we could improve overall implementation and performances by using pre-resolved data structures for traced files and packages and then apply new strategy from this. I have moved the additions and explanation to ~> #782 before merging them together. Please feel free to try it and suggest or directly make PR in top of it if i missed something. Cheers. |
π Linked issue
resolves #722
potentially resolves #612
β Type of change
π Description
This PR keeps both versions of conflicting dependencies by nesting them inside their parent.
It also introduces a new nitro option called
optimizeExternals
which allows you to manually include or exclude specific packages to the optimization process.π Checklist