Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cloudflare): add info regarding runtimeConfig and environment variables #958

Merged
merged 2 commits into from
Feb 20, 2023

Conversation

manniL
Copy link
Contributor

@manniL manniL commented Feb 18, 2023

πŸ”— Linked issue

Related: #272

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Give some info regarding CF env variables.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@manniL manniL changed the title docs: add info regarding runtimeConfig docs: add info regarding runtimeConfig + cloudflare Feb 18, 2023
@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Merging #958 (8835d2c) into main (5da951b) will increase coverage by 1.09%.
The diff coverage is n/a.

❗ Current head 8835d2c differs from pull request most recent head e2aeb4d. Consider uploading reports for the commit e2aeb4d to get more accurate results

@@            Coverage Diff             @@
##             main     #958      +/-   ##
==========================================
+ Coverage   66.50%   67.59%   +1.09%     
==========================================
  Files          57       59       +2     
  Lines        4221     6030    +1809     
  Branches      450      679     +229     
==========================================
+ Hits         2807     4076    +1269     
- Misses       1410     1945     +535     
- Partials        4        9       +5     
Impacted Files Coverage Ξ”
src/rollup/plugins/dynamic-require.ts 26.56% <0.00%> (-33.80%) ⬇️
src/storage.ts 17.50% <0.00%> (-30.99%) ⬇️
src/rollup/plugins/esbuild.ts 53.33% <0.00%> (-13.84%) ⬇️
src/presets/firebase.ts 18.01% <0.00%> (-12.51%) ⬇️
src/presets/azure.ts 8.57% <0.00%> (-7.67%) ⬇️
src/compress.ts 90.55% <0.00%> (-4.84%) ⬇️
src/presets/azure-functions.ts 21.62% <0.00%> (-4.41%) ⬇️
src/utils/tree.ts 12.12% <0.00%> (-3.88%) ⬇️
src/rollup/plugins/virtual.ts 97.14% <0.00%> (-2.86%) ⬇️
src/rollup/config.ts 88.30% <0.00%> (-2.78%) ⬇️
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 changed the title docs: add info regarding runtimeConfig + cloudflare docs(cloudflare): add info regarding runtimeConfig and environment variables Feb 20, 2023
@pi0 pi0 added the documentation Improvements or additions to documentation label Feb 20, 2023
@manniL manniL requested a review from pi0 February 20, 2023 11:23
@pi0 pi0 merged commit b11a0c4 into nitrojs:main Feb 20, 2023
@manniL manniL deleted the docs/cf-env branch February 20, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation preset:cloudflare
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants