forked from strangelove-ventures/horcrux
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threshold to main #38
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To keep up with upstream main
* Update raft-grpc-transport to fix close connections issue * Bump raft to v1.3.10 * Reset counter if block is signed to make test less flaky
Merge pull request strangelove-ventures#93 from chillyvee/add_prometheus
Co-authored-by: Andrew Gouin <andrew@gouin.io>
Add logs for participating cosigners (strangelove-ventures#111)
Fix: typos Co-authored-by: Andrew Gouin <andrew@gouin.io>
* Add tests for leader election and cleanup related code * lint fix * Show container logs for failed tests * Add retries for privval timeout * Add cmd to get current leader from CLI * wait for signed blocks after electing leader before checking leader among cluster * Make client package for address utils. Don't swallow errors * Simplify sanitize address
* Add assertions for t > n/2 for both key sharding and cosigner daemon start * Show container logs for failed tests * Update tests * Fix set state test * Prefer t.Setenv in tests. Fix error message
Threshold parameter validation (strangelove-ventures#112)
…trangelove-ventures#118) * Add signature and timestamp to log for adjusted timestamp visibility * Reduce line length * Handle empty Signature
* Threshold signer interface * local cosigner fix * fixed some minor renaming package * fix switch to casting * remove scope introducing block * fixed: TODO check true here is correct for async * Removed scope-introducing blocks * go lint fix * not all is fixed but most. * Fix the unreadabillity setting slots. * Update threshold_signer_soft.go * lint fix * Minor corrections and fixes * Variable cleaning up.
nitronit
commented
Nov 22, 2022
CosignerEphemeralSecretPart, error) { | ||
|
||
res := CosignerEphemeralSecretPart{} | ||
|
||
// protects the meta map | ||
m.LastSignStateMutex.Lock() | ||
defer m.LastSignStateMutex.Unlock() | ||
m.lastSignStateMutex.Lock() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be a wrapper?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.