Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added how to doc showing nix-shell and editing config #442

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JasonGoemaat
Copy link

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is what should have been placed here. Those are all normal NixOS things and we can just link to some upstream doc about this.

commands to use them:

```
[nixos@nixos:/mnt/c/t/nix]$ cowsay moo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't encourage people to run commands inside /mnt/ as it very slow. Please use a normal path like ~ in the examples.

Comment on lines +35 to +38
[nix-shell:/mnt/c/t/nix]$ exit
exit

[nixos@nixos:/mnt/c/t/nix]$
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[nix-shell:/mnt/c/t/nix]$ exit
exit
[nixos@nixos:/mnt/c/t/nix]$

Comment on lines +51 to +53
To add packages, edit `/etc/nixos/configuration.nix` using sudo. You
can use the `nano` editor which comes installed and uses CTRL+S to save
and CTRL+X to exit:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To add packages, edit `/etc/nixos/configuration.nix` using sudo. You
can use the `nano` editor which comes installed and uses CTRL+S to save
and CTRL+X to exit:
To add packages, edit `/etc/nixos/configuration.nix` using sudo.
You can use the `nano` editor which comes installed and uses CTRL+S to save and CTRL+X to exit:

We don't need to write blocksatz.

Comment on lines +61 to +63
```
environment.systemPackages = [ pkgs.cowsay pkgs.lolcat ];
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
environment.systemPackages = [ pkgs.cowsay pkgs.lolcat ];
}

...

environment.systemPackages = [ pkgs.cowsay pkgs.lolcat ];
}

@nzbr
Copy link
Member

nzbr commented Mar 28, 2024

Not sure if this is what should have been placed here. Those are all normal NixOS things and we can just link to some upstream doc about this.

Agreed, I think we should keep our docs to WSL specific things and point to some general NixOS guide

@aikooo7
Copy link

aikooo7 commented Apr 4, 2024

My 2 cents here but I also agree with the others. If we allowed this then we would need to keep it update with another documentation, why not just let the user open it by himself? Since they are using wsl2 it is assumed they can open the documentation with internet or pre-download it before.

@nzbr nzbr mentioned this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants