home-manager: handle missing per-user profiles directory #3742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note there are still references to the |
|
Unfortunately, I didn't have time to finish the changes but figured I'd create this draft PR to show that there is some action on the issue. Turns out we'll need to support both profile locations for the time being since we need to maintain some backwards compatibility. |
2 tasks
rycee
force-pushed
the
migrate-profiles-and-gcroot
branch
8 times, most recently
from
f7faeab
to
4de9bca
Compare
rycee
force-pushed
the
migrate-profiles-and-gcroot
branch
from
4de9bca
to
08f7821
Compare
Specifically, if the global per-user profiles path do not exist and we cannot create it during the activation, then place our profile in the Home Manager data directory. We prefer to use the global location, though, since it makes it visible to `nix-collect-garbage`. This is intended to improve compatibility with Nix version 2.14 and later, which no longer creates the per-user directories. Also, use the Home Manager data directory to manage the gcroot for the current generation. It does not have to sit in the global per-user gcroots directory since it should never be eligible for GC.
rycee
force-pushed
the
migrate-profiles-and-gcroot
branch
from
08f7821
to
f698164
Compare
7 tasks
|
Thanks for the fast fix here ❤️ |
2 tasks
|
N.B. you will want to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Specifically, if the global per-user profiles path do not exist and we cannot create it during the activation, then place our profile in the Home Manager data directory. We prefer to use the global location, though, since it makes it visible to
nix-collect-garbage.This is intended to improve compatibility with Nix version 2.14 and later, which no longer creates the per-user directories.
Also, use the Home Manager data directory to manage the gcroot for the current generation. It does not have to sit in the global per-user gcroots directory since it should never be eligible for GC.
Checklist
Change is backwards compatible. Assuming no reliance on location of gcroot and profile.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like