Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow forcing home-manager to use nix flake profiles instead of old nix with an option #5523

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tnichols217
Copy link

Description

I added a new option to fix an odd bug where home-manager fails to activate if the .drvs are not present in the store. This happens because old nix needs them for some weird reason, and I'm not going to fix that, however nix flakes do not require them, so I created this option to allow forcing home-manager to use the new nix flake profiles instead of old nix.

Fixes #4928

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@rycee

Added a new option home.forceNixProfiles to force the usage of 'nix profile' and not 'nix-env'
Fixes nix-community#4928 as nix profiles do not require the presence of .drvs
Copy link

stale bot commented Sep 15, 2024

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

@stale stale bot added the status: stale label Sep 15, 2024
@stale stale bot removed the status: stale label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: home-manager fails to activate when .drvs are not present in the nix-store
1 participant