-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
espanso: add wayland support #5930
base: master
Are you sure you want to change the base?
Conversation
Edit: I don't know why the test is failing, espanso-wayland is in nixpkgs and |
62b4610
to
82dc0c3
Compare
One thing is clear, for it to work seamlessly without explicitly requiring user to choose wayland or x11 the only solution is the upstream espanso package should provide a In this pr the fat binary is But I guess on darwin there is no such thing as wayland and thus the more things to consider
|
1b29b51
to
8c87251
Compare
b569a52
to
892521f
Compare
892521f
to
974d73b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
974d73b
to
8f4e534
Compare
Fixed the test (with the |
674a6a8
to
13c09bd
Compare
13c09bd
to
60d6efe
Compare
@rycee I need some help, please have a look at it when you're free. $ nix build .#test-espanso-basic-configuration
error:
… while calling the 'derivationStrict' builtin
at <nix/derivation-internal.nix>:34:12:
33|
34| strict = derivationStrict drvAttrs;
| ^
35|
… while evaluating derivation 'nmt-test-espanso-basic-configuration'
whose name attribute is located at /nix/store/riqkpszjqk02bi1wppfg8ip5xvh102qd-source/pkgs/stdenv/generic/make-derivation.nix:336:7
… while evaluating attribute 'buildCommand' of derivation 'nmt-test-espanso-basic-configuration'
at /nix/store/riqkpszjqk02bi1wppfg8ip5xvh102qd-source/pkgs/build-support/trivial-builders/default.nix:59:17:
58| enableParallelBuilding = true;
59| inherit buildCommand name;
| ^
60| passAsFile = [ "buildCommand" ]
… while evaluating the option `home.activation.installPackages.data':
… while evaluating definitions from `/nix/store/vv3xqpi8hwcciy7labjysw3s6qwafch4-source/modules/home-environment.nix':
… while evaluating the option `services.espanso.package-wayland':
(stack trace truncated; use '--show-trace' to show the full, detailed trace)
error: attribute 'override' missing
at /nix/store/riqkpszjqk02bi1wppfg8ip5xvh102qd-source/pkgs/top-level/all-packages.nix:4857:21:
4856| };
4857| espanso-wayland = espanso.override {
| ^
4858| x11Support = false; |
60d6efe
to
caa9418
Compare
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
caa9418
to
1bd6729
Compare
Tested on kde plasma x11 and wayland sessions. and inside niri wm (wayland). works ok