Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assertion that config.nixpkgs cannot be set if useGlobalPkgs is enabled #6172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

justDeeevin
Copy link

Description

When useGlobalPkgs is enabled, setting nixpkgs.config and nixpkgs.overlays in the home config has no effect. There is an assertion in place intended to throw an error if the user tries to set these options in this scenario, but it uses an OR instead of an AND, allowing for one of them to be set. This PR replaces this OR for an AND.

Fixes #6079.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@thiagokokada

This fixes the assertion that `config.nixpkgs` cannot be set if
`useGlobalPkgs` is enabled
@justDeeevin
Copy link
Author

Been a minute... what's left to get this merged?

Copy link
Contributor

@Adda0 Adda0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I do not think there is anything left to do. The PR just needs to wait for someone to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants