zed-editor: fix always generating settings.json #6201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it so settings.json no longer gets made by ensuring it can be empty as expected when there are no extensions or userSettings defined.
|
I've attempted to run the tests but have received the following error which i dont believe has anything to do with my changes but I'm not sure why is failing.
|
rycee
pushed a commit
that referenced
this pull request
Dec 13, 2024
Makes it so settings.json no longer gets made by ensuring it can be empty as expected when there are no extensions or userSettings defined. PR #6201
|
Thanks! Rebased to master in 66c5d8b 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes it so settings.json no longer gets made by ensuring it can be empty as expected when there are no extensions or userSettings defined.
Previously settings.json would always be generated because even if there were no extensions defined an empty value would still be made.
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.allornix develop --ignore-environment .#allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC
@libewa
Fixes #6193