hm: option for default linking method #182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm there are no diffs in my home path when running this branch versus the main branch |
|
I've been using this PR for about a week now and everything is working great on my end. Thank you both for your work on this PR and project :) |
talyz
requested changes
Jun 7, 2024
| specially by some programs that may e.g. generate | ||
| errors/warnings, or replace them. | ||
|
|
||
| This can be overrided on a per entry basis. |
There was a problem hiding this comment.
Suggested change
| This can be overrided on a per entry basis. | |
| This can be overridden on a per entry basis. |
| getDirMethod = v: v.method or "bindfs"; | ||
| isBindfs = v: (getDirMethod v) == "bindfs"; | ||
| isSymlink = v: (getDirMethod v) == "symlink"; | ||
| getDirPath = v: v.directory; |
There was a problem hiding this comment.
Since you're removing all the other accessors, maybe this one should go, too?
|
Hi @talyz @Misterio77 Don't want to necrobump, but is there something except minor comments blocking this PR? This feature would be handy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
Here's a (slightly late) follow up to #99.
This adds an option that allows users to change the default linking method.
Bindfs has been bothering me with the performance hits, and writing
method = symlinkfor every entry is cumbersome. The default still is bindfs, so no breaking changes.To make this implementation cleaner, I also refactored the directory type to use coercedTo (in its own commit, to be easier to review).