nh: mock tests, VM tests and other testing infra #258
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faukah
reviewed
May 3, 2025
faukah
approved these changes
May 4, 2025
NotAShelf
changed the title
NotAShelf
changed the title
NotAShelf
changed the title
Member
|
Oh I was going to do this part of basic testing then this pr happened.... Well I can still help you what tests are left to do? |
Member
Author
|
What's left to do now is to rebase on my other PR, and add new unit tests. It'd be nice to finish NixOS VM tests, but I'm handling that in a separate PR. |
Member
Author
|
Most changes were cherry picked into different PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a large change that spiraled out of control a little as I wanted to do more and more. Initially this change was to move nh checks into a separate module, and remove unused functions from utils. Though, on the theme of "checks", I also decided to add some tests etc. Now it's a 2k diff that Viper will not review
Adds a bunch of tests, VM tests, etc. Closes #237Complete testing infrastructure to make sure we never break user interface by accident, and that everything continues to work as intended on every change. Quite a large change, but does not affect the users in any way.