-
-
Notifications
You must be signed in to change notification settings - Fork 74
meta: fix typos and broken link #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a ElasticSearch -> an ElasticSearch platfom -> platform thee -> the
the default branch name was changed from main to master
|
Note Reviews pausedUse the following commands to manage reviews:
WalkthroughUpdated the PR template changelog link from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Pre-merge checks (3 passed)✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
.github/PULL_REQUEST_TEMPLATE.md (2)
4-8: Fix grammar: “please bug”.Suggest correcting the sentence.
-of the added plugin or dependency in this section. If your pull request aims to -fix an open issue or a please bug, please also link the relevant issue below this +of the added plugin or dependency in this section. If your pull request aims to +fix an open issue or a bug, please also link the relevant issue below this
30-31: Typo: “docunentation” → “documentation”.- - [ ] I have added appropriate docunentation to new code + - [ ] I have added appropriate documentation to new codeREADME.md (2)
86-87: Brand style: “Elasticsearch”, not “ElasticSearch”.Official spelling is “Elasticsearch” (single word, lowercase “s”). Recommend:
-- `nh search` - a super-fast package searching tool (powered by an ElasticSearch +- `nh search` - a super-fast package searching tool (powered by an Elasticsearch
144-145: Minor style: duplicated “today”.-You can try NH today in a Nix shell today, no setup required! +You can try NH in a Nix shell today, no setup required!
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/PULL_REQUEST_TEMPLATE.md(1 hunks)README.md(3 hunks)
🔇 Additional comments (3)
.github/PULL_REQUEST_TEMPLATE.md (1)
23-23: Changelog link target looks correct.Default branch is currently “master” and
CHANGELOG.mdexists at repo root, so this URL should resolve as intended. (github.com)README.md (2)
278-279: LGTM — typo fixed.“platfom” → “platform” is correct.
296-301: LGTM — wording fix.“thee” → “the” reads correctly.
|
My beloved proofreader is back... |
|
@coderabbitai ignore |
✅ Actions performedReviews paused. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ain't no bot gonna review my favorite proofreader
LGTM
Fix various typos.
Additionally fix broken changelog link in the pull request template, as the default branch name was changed from
maintomaster(I think).Add a 👍 reaction to pull requests you find important.
Summary by CodeRabbit
Documentation
Chores