Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --top-level the default behavior of nix-locate #243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Feb 24, 2024

It happens pretty often to me that I'm trying to find out which packages contain a certain header file (e.g. unistd.h). In those cases I usually don't care at all about which e.g. FHS env has this header as well.

I can't remember a single time where this was actually helpful, so I'm questioning whether this is a sensible default. I'll use this patch in my own setup for now, but I thought I could suggest it here as well.

cc @RaitoBezarius @figsoda @bennofs

It happens pretty often to me that I'm trying to find out which packages
contain a certain header file (e.g. `unistd.h`). In those cases I
usually don't care at all about which e.g. FHS env has this header as
well.

I can't remember a single time where this was actually helpful, so I'm
questioning whether this is a sensible default. I'll use this patch in
my own setup for now, but I thought I could suggest it here as well.
@Ma27 Ma27 force-pushed the top-level-default branch from 2b48ed1 to 66cd679 Compare May 27, 2024 15:42
@Ma27
Copy link
Member Author

Ma27 commented May 27, 2024

Rebased onto latest master now.
Friendly ping @K900 @RaitoBezarius

Copy link
Contributor

@K900 K900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doronbehar
Copy link
Contributor

Looks good to me ! Waiting for this to get in...

@Frontear
Copy link

Frontear commented Nov 15, 2024

Bump, this would be nice to get in! I've already used it through a personal patch and it works like a charm.

EDIT: sorry for the cross-links, GitHub doesn't like that I force pushed to update the commit description.

Frontear added a commit to Frontear/dotfiles that referenced this pull request Nov 15, 2024
This is part of a PR over at nix-community/nix-index#243 which makes --top-level a default argument. This in turn removes FHS entries by default from being matched when using `nix-locate`. This was always a pain point for me so I am glad someone knew how to fix it. Unfortunately since that PR seems a bit stalled I've in turn needed to patch directly. I've poked upstream to help move that PR along, and once it does merge I'll drop this patch.
Frontear added a commit to Frontear/dotfiles that referenced this pull request Nov 15, 2024
This is part of a PR over at https://github . com/nix-community/nix-index/pull/243 which makes `--top-level` a default argument. This in turn removes FHS entries by default from being matched when using `nix-locate`. This was always a pain point for me so I am glad someone knew how to fix it. Unfortunately since that PR seems a bit stalled I've in turn needed to patch directly. I've poked upstream to help move that PR along, and once it does merge I'll drop this patch.
Frontear added a commit to Frontear/dotfiles that referenced this pull request Nov 15, 2024
This is part of a PR over at nix-community/nix-index#243 which makes `--top-level` a default argument. This in turn removes FHS entries by default from being matched when using `nix-locate`. This was always a pain point for me so I am glad someone knew how to fix it. Unfortunately since that PR seems a bit stalled I've in turn needed to patch directly. I've poked upstream to help move that PR along, and once it does merge I'll drop this patch.
Frontear added a commit to Frontear/dotfiles that referenced this pull request Nov 26, 2024
This is part of a PR over at nix-community/nix-index#243 which makes `--top-level` a default argument. This in turn removes FHS entries by default from being matched when using `nix-locate`. This was always a pain point for me so I am glad someone knew how to fix it. Unfortunately since that PR seems a bit stalled I've in turn needed to patch directly. I've poked upstream to help move that PR along, and once it does merge I'll drop this patch.
Frontear added a commit to Frontear/dotfiles that referenced this pull request Nov 26, 2024
This is part of a PR over at nix-community/nix-index#243 which makes `--top-level` a default argument. This in turn removes FHS entries by default from being matched when using `nix-locate`. This was always a pain point for me so I am glad someone knew how to fix it. Unfortunately since that PR seems a bit stalled I've in turn needed to patch directly. I've poked upstream to help move that PR along, and once it does merge I'll drop this patch.
Frontear added a commit to Frontear/dotfiles that referenced this pull request Nov 26, 2024
This is part of a PR over at nix-community/nix-index#243 which makes `--top-level` a default argument. This in turn removes FHS entries by default from being matched when using `nix-locate`. This was always a pain point for me so I am glad someone knew how to fix it. Unfortunately since that PR seems a bit stalled I've in turn needed to patch directly. I've poked upstream to help move that PR along, and once it does merge I'll drop this patch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants