feat: inherit Eglot's nix-mode settings #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purcell
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
I guess derived-mode-add-parents is new in Emacs HEAD: it's not in any released version of Emacs. Snippets like this do appear to be routinely used for this purpose in Emacs, so I'm generally in favour.
|
That's the main reason why I encapsulated the function with a |
Yep, appreciated that, thanks. :) |
|
Comment was meant as "huh, today I learned" as much as anything. |
|
Aha, gotcha! Glad to help out! 😄 |
|
Merged now, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change is to inherit the defined configuration for
nix-modewithineglot-server-programsto automate the process of setting up Eglot for this mode.Current (as of commit date) value for
nix-modefound withineglot-server-programs: