Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix line indentation stripping #62

Merged
merged 4 commits into from
Jul 28, 2023
Merged

Fix line indentation stripping #62

merged 4 commits into from
Jul 28, 2023

Conversation

infinisil
Copy link
Collaborator

@infinisil infinisil commented Jul 20, 2023 •
edited
Loading

Fixes #1, line indentations being stripped.

This work is sponsored by Antithesis ✨

Ping @pennae

@infinisil infinisil changed the title Indentation Fix line indentation stripping Jul 20, 2023
@infinisil infinisil mentioned this pull request Jul 20, 2023
Merged
2 tasks
@infinisil
Copy link
Collaborator Author

Now using dedent for less code, as suggested by @pennae on Matrix :)

pennae
pennae reviewed Jul 20, 2023
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
pennae
pennae approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@pennae pennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks alright :)

hoping we'll at some point get an actual standard notation instead of the hacky parser we have now being used as a definition though

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-07-24-documentation-team-meeting-notes-66/30885/1

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-07-27-documentation-team-meeting-notes-67/30998/1

@infinisil infinisil force-pushed the indentation branch 2 times, most recently from 9bc64be to 33482e7 Compare July 28, 2023 15:52
infinisil and others added 4 commits July 28, 2023 18:00
@infinisil @pennae
Fix line indentation stripping
46098c2 
Previously all the indentation was stripped all the time

Co-authored-by: pennae <82953136+pennae@users.noreply.github.com>
@infinisil
Render multi-line types with triple backticks
0e74202 
Arguably this shouldn't even be allowed, but erroring would not be in line
with how nixdoc works otherwise :)
@infinisil
Add rustc to the dev environment
fa0d63c
@infinisil
Gitignore .direnv and result
7eb8c36
@asymmetric asymmetric merged commit cd6c4be into nix-community:master Jul 28, 2023
@infinisil infinisil deleted the indentation branch July 28, 2023 16:15
@infinisil infinisil mentioned this pull request Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pennae pennae pennae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Whitespace is not preserved properly
4 participants
@infinisil @nixos-discourse @pennae @asymmetric