Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CUDA in WSL2 #44

Closed
wants to merge 8 commits into from
Closed

Support CUDA in WSL2 #44

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
18929af
Support CUDA in WSL
Atry Feb 11, 2023
665d997
Update auto-fix-vscode-server.nix
Atry Feb 11, 2023
2ad8c41
Update auto-fix-vscode-server.nix
Atry Feb 11, 2023
9a6e652
Update auto-fix-vscode-server.nix
Atry Feb 11, 2023
d4880cf
Update auto-fix-vscode-server.nix
Atry Feb 11, 2023
a078e27
Update auto-fix-vscode-server.nix
Atry Feb 11, 2023
2dbab3f
Update auto-fix-vscode-server.nix
Atry Feb 11, 2023
51e95fa
Merge branch 'master' into patch-1
Atry Feb 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkgs/auto-fix-vscode-server.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,13 @@ let
;
}) ++ extraFHSPackages pkgs;

extraBuildCommands = ''
if [[ -d /usr/lib/wsl ]]
then
cp -rsHf /usr/lib/wsl usr/lib/wsl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we symlink?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cp -rsHf is already symlinking.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://linux.die.net/man/1/cp#:~:text=%2Dn%20option)-,%2DH,-follow%20command%2Dline

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems cp -rsHf is used in nixpkgs to link other libraries.

https://github.com/NixOS/nixpkgs/blob/3d53723112c6045bd6534ebeb536056fec5a16f8/pkgs/build-support/build-fhs-userenv/env.nix#L192

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Atry Thanks for clarifying, I wasn't aware it was symlinking either. I will keep it as it is then in PR #47, but I will add a comment about it actually symlinking for clarify sake.

fi
'';

runScript = "${nodejs}/bin/node";

meta = {
Expand Down