flake/generate-files: move most assertions to check derivation
#1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What commit prefix should we be using for the update/gen-files stuff? It seems we've been somewhat inconsistent... |
GaetanLepage
previously approved these changes
Jul 31, 2024
MattSturgeon
force-pushed
the
update-test
branch
from
ea33814
to
7fea20d
Compare
This moves most assertions out of generate-files and into a check derivation. This should allow the CI to finish, even when there are issues. This also properly tests efmls, which was only checked partially before. rust-analyzer is not covered because the existing assertions relate more to edge-cases not handled by the generation script than the result it builds.
Running `nix fmt` is unnecessary in this case.
MattSturgeon
force-pushed
the
update-test
branch
from
7fea20d
to
3789c69
Compare
|
@GaetanLepage I've dismissed your approval since I've updated the implementation. Thanks for your early review though! I've also tested that the update action is able to run on this branch: https://github.com/MattSturgeon/nixvim/actions/runs/10178853612 I've tested the test itself by adding/removing random entries from the none-ls/efmls package declaration files, and everything seems correct: |
MattSturgeon
changed the title
check derivationcheck derivation
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 3789c69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the none-ls and efmls assertions out of the generation scripts and into a separate "test" derivation run by
nix flake checkand buildbot.I didn't move the rust-analyzer assertions since they seem more related to the generation script itself, rather than the output it produces.
I've also made some other improvements to the generation script, such as using nixfmt directly and passing all derivations in via string context instead of calling
nix buildmultiple times.I'll probably go over this again in the daytime since I think the test derivation can be simplified further.