Skip to content

Conversation

@khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Aug 23, 2024

Resolves #2064

@khaneliman khaneliman force-pushed the conform branch 6 times, most recently from 7413b61 to 64b840b Compare August 24, 2024 04:56
@khaneliman khaneliman marked this pull request as ready for review August 24, 2024 04:58
@khaneliman khaneliman force-pushed the conform branch 6 times, most recently from 24dd223 to 29b12b0 Compare August 24, 2024 05:29
@khaneliman khaneliman force-pushed the conform branch 2 times, most recently from ec5adc1 to 2756fcd Compare August 24, 2024 15:44
@khaneliman
Copy link
Contributor Author

Updated to mark those options as removed, user's just need to update to nest them under the new settings option so migration is quick and painless.

Copy link
Member

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this is the only remaining issue; sorry I missed it earlier!

Copy link
Member

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks again

@khaneliman khaneliman force-pushed the conform branch 4 times, most recently from f1e50fd to 1d901c8 Compare August 24, 2024 16:45
@khaneliman
Copy link
Contributor Author

Last push was just making it include syntax highlighting.

@khaneliman
Copy link
Contributor Author

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2024

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 89b876d

@mergify mergify bot merged commit 89b876d into nix-community:main Aug 24, 2024
@mergify mergify bot temporarily deployed to github-pages August 24, 2024 17:27 Inactive
@khaneliman khaneliman deleted the conform branch August 24, 2024 17:27
Copy link
Member

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using literalMD for an example is a little unconventional, but everything seems fine. Thanks for another high value PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Conform plugin config using deprecated syntax for stop after first formatter

2 participants