plugins/hex: init #2204
Merged
plugins/hex: init #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaetanLepage
force-pushed
the
hex
branch
2 times, most recently
from
8392a5b to
5fb75a5
Compare
MattSturgeon
approved these changes
Sep 9, 2024
plugins/by-name/hex/default.nix
Outdated
Comment on lines
13
to
19
| xxdPackage = lib.mkPackageOption pkgs "xxd" { | ||
| default = [ | ||
| "unixtools" | ||
| "xxd" | ||
| ]; | ||
| nullable = true; | ||
| }; |
There was a problem hiding this comment.
Up to you, but when the name is the same as the last element of the default, you can also use mkPackageOption like this:
lib.mkPackageOption pkgs [
"unixtools"
"xxd"
] { nullable = true; }There was a problem hiding this comment.
Also note: you'll be pleased to hear nixfmt will start formatting this as the following soon:
lib.mkPackageOption pkgs [ "unixtools" "xxd" ] { nullable = true; }As short lists will be allowed to stay contracted when used as function arguments.
Just need NixOS/nixfmt#233 to make it to our nixpkgs lock 😁
There was a problem hiding this comment.
Up to you, but when the
nameis the same as the last element of thedefault, you can also usemkPackageOptionlike this:lib.mkPackageOption pkgs [ "unixtools" "xxd" ] { nullable = true; }
Good to know, I changed it.
|
@Mergifyio queue |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at ffa9b8f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds hex.nvim.
Fixes #2187