lib/modules: assert that specialArgs has a valid lib
#2322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattSturgeon
force-pushed
the
assert_specialArg_lib
branch
3 times, most recently
from
a1d75f6 to
fa66fd5
Compare
End-users have ran into issues before when attempting to re-use a `lib` from elsewhere in nixvim's configuration. If a `lib` without the `nixvim` extension is used, this assertion will inform the user that this isn't supported. In the future we can also provide better ways for end-users to overlay their own lib with nixvim's extensions, but this is not yet implemented. Co-authored-by: Gaétan Lepage <33058747+GaetanLepage@users.noreply.github.com>
MattSturgeon
force-pushed
the
assert_specialArg_lib
branch
from
c579efb to
6b0c5d5
Compare
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 6b0c5d5 |
|
This pull request, with head sha This pull request will be automatically closed by GitHub.As soon as GitHub detects that the sha It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-users have ran into issues before when attempting to re-use a
libfrom elsewhere in nixvim's configuration.If a
libwithout thenixvimextension is used, the new assertion will explain that this isn't supported.In the future we can also provide better ways for end-users to overlay their own lib with nixvim's extensions, but this is not yet implemented. Draft #2328