create subfolder at top level of tarball from Github #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshaynik
force-pushed
the
package-dir-in-tar
branch
from
7d3a024
to
2255315
Compare
create a package dir at top level of tarball from Github Tarballs that npm can use, package contents should reside in a subfolder inside the tarball (usually it is called package/). npm strips one directory layer when installing the package (an equivalent of tar x --strip-components=1 is run). See https://docs.npmjs.com/cli/v7/commands/npm-install
tshaynik
force-pushed
the
package-dir-in-tar
branch
from
2255315
to
67c3a90
Compare
|
Interesting issue. Do you have a reproducer for this issue? |
|
@tshaynik Ping, a reproducer would be great, we could turn this into a test case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create a package dir at top level of tarball from Github
to fix bug where npm install cannot resolve dependencies.
This fix resolves ENOTCACHED errors in the preinstall phase
caused by improperly structured tarballs.
Tarballs that npm can use, package contents should reside
in a subfolder inside the tarball (usually it is called package/).
npm strips one directory layer when installing the package
(an equivalent of tar x --strip-components=1 is run).
See https://docs.npmjs.com/cli/v7/commands/npm-install
This relates to issue #45.