This repository has been archived by the owner on Jan 25, 2024. It is now read-only.
add autocomplete via evaluation #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronjanse
commented
Nov 17, 2021
| @@ -43,12 +43,23 @@ impl Expr { | |||
| /// rnix::SyntaxNode isn't recognized, we don't get tooling for its children. | |||
| pub fn parse(node: SyntaxNode, scope: Gc<Scope>) -> Result<Self, EvalError> { | |||
| let range = Some(node.text_range()); | |||
| let recurse_box = |node| Expr::parse(node, scope.clone()).map(|x| Box::new(x)); | |||
| let recurse_gc = |node| Expr::parse(node, scope.clone()).map(|x| Gc::new(x)); | |||
| // We don't want to use ? because that would make a parent fail | |||
There was a problem hiding this comment.
I'm going to move this into a separate PR
|
To minimize confusion, I'll close this PR then re-open it when its dependency PRs are merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This allows users to auto-complete based on evaluation. This is especially helpful for selecting from attribute sets.
This PR prioritizes existing static analysis completions over completions provided by the evaluator, since existing functionality is known to work well.
Auto-complete for the evaluator shows up immediately after pressing the period key. This does not work for the static
builtins. I looked into changing that, but I think it would require enough effort to warrant a separate (but still small) PR.Further context
This depends upon graceful error handling in rnix-parser. I've been testing this PR with nix-community/rnix-parser#34 (see the comments this PR adds to the
Cargo.tomlfor details on patching rnix-parser while developing).