improved error handling #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronjanse
commented
Jul 27, 2022
src/parser.rs
Outdated
Comment on lines
335
to
342
| match self.peek_any_or_missing(&[TOKEN_INTERPOL_START, TOKEN_STRING_START, TOKEN_IDENT]) { | ||
| Some(TOKEN_INTERPOL_START) => self.parse_dynamic(), | ||
| Some(TOKEN_STRING_START) => self.parse_string(), | ||
| Some(TOKEN_IDENT) => self.expect_ident(), | ||
| _ => { | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
I personally don't love the repetition here, but I think it's not too bad?
aaronjanse
force-pushed
the
err-handling-take2
branch
from
56ba050
to
a556bb3
Compare
aaronjanse
commented
Jul 27, 2022
| @@ -0,0 +1 @@ | |||
| { foo = 1 bar = 2} // { xyz = 3; } | |||
There was a problem hiding this comment.
It's fun seeing how Github syntax highlighting, on the other hand, is not fault-tolerant
|
I now realize this duplicates work done by @oberblastmeister in #35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This adds helper methods for expecting a token, bumping only if it exists. Using these methods, I improved error handling in two ways:
{ foo = 1 } // { bar = 2; }will now be parsed correctly, with the needed semicolon token simply missing (and appropriate error). Previously, this was parsed as one set with a large error node.{ foo = bar.; xyz = 1; }are parsed as missing an attractive path rather than having a large error node consuming most of the tokens.Further context
Replaces #34. This PR is needed to implement autocomplete in rnix-lsp for expressions like
foo.. I'm sure several other tools will find improved error handling helpful too.