This repository has been archived by the owner on May 20, 2021. It is now read-only.
Automatic Yarn Workspace import #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See nix-community#57 for the initial ticket. nix-community#58 adds the basic plumbing, but requires you to manually define the workspace. This will automatically import the "master" `package.json` and find all subpackages.
nightkr
added a commit
to Etimo/photo-garden
that referenced
this pull request
Jun 26, 2018
This is thanks to the new `mkYarnWorkspace` (nix-community/yarn2nix#59)
zimbatm
approved these changes
Jun 27, 2018
|
thanks! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #57 for the initial ticket. #58 adds the basic plumbing, but requires you to manually define the workspace. This will automatically import the "master"
package.jsonand find all subpackages.This is a bit more complicated than it has any right to be. Most of this is because it tries to implement Yarn's (and most shells') globbing behaviour. Maybe that should be moved to Nixpkgs' lib eventually, since it doesn't really have anything to do with Yarn in particular...