Skip to content
This repository has been archived by the owner on May 20, 2021. It is now read-only.

mkYarnWorkspace ignores workspace paths which yarn would ignore #89

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nicknovitski
Copy link
Member

Directories which match the workspace globs are ignored if:

  • they do not have package.json files
  • their package.json files don't have a name field
  • their package.json files don't have a version field

(Yarn ignores these, either silently or with a warning)

Directories which match the workspace globs are ignored if:
- they do not have package.json files
- their package.json files don't have a name field
- their package.json files don't have a version field
@nicknovitski
Copy link
Member Author

nicknovitski commented Dec 1, 2018

Hmm. This doesn't work with one of our workspace repositories.

e: example removed and replaced with a new failing test

@nicknovitski
Copy link
Member Author

I added a failing test using facebook/nuclide.

@nicknovitski
Copy link
Member Author

error: while evaluating 'mkYarnWorkspace' at /home/travis/build/moretea/yarn2nix/default.nix:144:21, called from /home/travis/build/moretea/yarn2nix/tests/default.nix:24:12:
while evaluating 'validPackage' at /home/travis/build/moretea/yarn2nix/default.nix:170:20, called from undefined position:
string '/nix/store/sajg9gp91rhhn9yyvlrzbfdsp8ypvr44-source/modules/atom-ide-debugger-java/package.json' cannot refer to other paths, at /home/travis/build/moretea/yarn2nix/default.nix:175:9

Very strange. It's possible to use import and readFile on derivations, but not pathExists? I'm trying very hard to find something I did wrong, but if I can't then I think it's an issue with nix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant