This repository was archived by the owner on May 20, 2021. It is now read-only.
Move fetching into Nix and allow custom fetching #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a `yarnFetch` argument that can be used to specify a custom fetcher. This is useful to weave in calls to fetchgitPrivate, or fetchurl with authentication via `netrcPhase` and `netrcImpureEnvVars`. Implementations of yarnFetch must return the resulting path, and can chain to the default behavior by calling `defaultYarnFetch`.
zimbatm
approved these changes
Apr 25, 2019
| @@ -15,7 +15,7 @@ function urlToName(url) { | |||
|
|
|||
| return url | |||
| .replace('https://registry.yarnpkg.com/', '') // prevents having long directory names | |||
| .replace(/[@/:-]/g, '_') // replace @ and : and - characters with underscore | |||
There was a problem hiding this comment.
is it possible to add a test-case that reproduces the issue?
I think this happens when the URL contains %2f for example which might mean the URL has to be url-decoded instead.
| # Loads the generated offline cache. This will be used by yarn as | ||
| # the package source. | ||
| importOfflineCache = yarnNix: | ||
| let | ||
| pkg = callPackage yarnNix { }; |
There was a problem hiding this comment.
it's nice that callPackage is not needed anymore
| ref = "${branch}"; | ||
| rev = "${rev}"; | ||
| }; | ||
| }` |
There was a problem hiding this comment.
there is an opportunity to return JSON data here and process the result with a JSON2nix converter function higher in the call stack
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to make
yarn2nix(the program) emit pure data instead of code, and then interpret that on the Nix side. For the case of tarring up git dependencies, it means not having to embed the tar call in the generated file. It also allows custom fetchers which can embed authentication for access to private registries.While I'm here, remove instances of
%in names. I observed this in a url escaped slash (%2f).This is is a breaking change to the generated dependency file format. All consumers will have to regenerate their yarn.nix files.