Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AsRawFd for nix::dir::OwningIter #1558

Closed
deantvv opened this issue Oct 14, 2021 · 1 comment
Closed

Add AsRawFd for nix::dir::OwningIter #1558

deantvv opened this issue Oct 14, 2021 · 1 comment

Comments

@deantvv
Copy link
Contributor

deantvv commented Oct 14, 2021

OwningIter is just a wrapper around Dir which implements AsRawFd which makes this easy (or even trivial) to implement.

The only thing that I could think of this may be unsound is after calling drop() on Dir will make the RawFd invalid but this is the same as AsRawFd for Dir which will also suffer from this issue. Link is the discussion of AsRawFd in stdlib.

I can implement this if this feature is approved.
deantvv added a commit to deantvv/nix that referenced this issue Oct 16, 2021
@deantvv
Impl AsRawFd for OwningIter
89d6f9e 
For issue nix-rust#1558
@deantvv deantvv mentioned this issue Oct 16, 2021
Merged
deantvv added a commit to deantvv/nix that referenced this issue Feb 6, 2022
@deantvv
Impl AsRawFd for OwningIter
e0e64fa 
For issue nix-rust#1558
deantvv added a commit to deantvv/nix that referenced this issue Feb 7, 2022
@deantvv
Impl AsRawFd for OwningIter
378530d 
For issue nix-rust#1558
bors bot added a commit that referenced this issue Feb 7, 2022
@bors @deantvv
Merge #1563
0244b83 
1563: Impl `AsRawFd` for `OwningIter` r=rtzoeller a=deantvv

For issue #1558

Co-authored-by: Dean Li <deantvv@gmail.com>
@deantvv
Copy link
Contributor Author

deantvv commented Feb 13, 2022

Close since it is already merge in #1563

@deantvv deantvv closed this as completed Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@deantvv