Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sendmmsg() / recvmmsg() #1017
Add sendmmsg() / recvmmsg() #1017
Changes from all commits
fc23427
ba40139
83dc6c2
1e2dd8d
898baa2
21f6644
0b571b7
ada4296
65b2ae0
a4ade88
defb24a
b2ffef3
22c9a90
8b5d16a
a61d2ef
dadfe3f
de7df0e
1e79bf0
4a3b203
ca4611d
c709020
8182cb3
481c286
2dc8647
5490901
66b9292
52b081d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description is blisfully out-of-date. You can remove the "on Linux" part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is duplicative. Can you think of any way to share code between this method and
as_ffi_pair
? Also, you should wrap to 80 cols.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent for consistency's sake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: on
musl
theflag
argument is anunsigned int
, while ongnu
, it is a signed int, so one probably needs anas _
here as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very complicated function to use. Could you provide an example? Also, why no
flags
argument?