Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fcntl.rs #1065

Merged
merged 1 commit into from
May 23, 2019
Merged

Update fcntl.rs #1065

merged 1 commit into from
May 23, 2019

Conversation

kubkon
Copy link
Contributor

@kubkon kubkon commented May 23, 2019

Just a minor typo in the docs of O_RDWR. It read:

/// Allow both reading and writing.
///
/// This should not be combined with `O_WRONLY` or `O_RDWR`.
O_RDWR;

but I believe it should read

/// Allow both reading and writing.
///
/// This should not be combined with `O_WRONLY` or `O_RDONLY`.
O_RDWR;

instead :-)

@kubkon
Update fcntl.rs
a77e500 
Just a minor typo in the docs of `O_RDWR`. It read:

```
/// Allow both reading and writing.
///
/// This should not be combined with `O_WRONLY` or `O_RDWR`.
O_RDWR;
```

but I believe it should read

```
/// Allow both reading and writing.
///
/// This should not be combined with `O_WRONLY` or `O_RDONLY`.
O_RDWR;
```

instead :-)
asomers
asomers approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

bors r+

bors bot added a commit that referenced this pull request May 23, 2019
@bors @kubkon
Merge #1065
4a2fcba 
1065: Update fcntl.rs r=asomers a=kubkon

Just a minor typo in the docs of `O_RDWR`. It read:

```
/// Allow both reading and writing.
///
/// This should not be combined with `O_WRONLY` or `O_RDWR`.
O_RDWR;
```

but I believe it should read

```
/// Allow both reading and writing.
///
/// This should not be combined with `O_WRONLY` or `O_RDONLY`.
O_RDWR;
```

instead :-)

Co-authored-by: Jakub Konka <kubkon@jakubkonka.com>
@bors
Copy link
Contributor

bors bot commented May 23, 2019

Build succeeded

@bors bors bot merged commit a77e500 into nix-rust:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kubkon @asomers