Add support for UTIME_NOW and UTIME_OMIT to TimeSpec #1103
Conversation
|
I don't think this works on OSX |
src/sys/time.rs
Outdated
| @@ -144,6 +144,20 @@ impl TimeValLike for TimeSpec { | |||
| } | |||
|
|
|||
| impl TimeSpec { | |||
| /// Makes a new `TimeSpec` with the special UTIME_NOW constant | |||
| #[inline] | |||
There was a problem hiding this comment.
No need for #[inline]. The compiler can figure that out for itself.
src/sys/time.rs
Outdated
| @@ -144,6 +144,20 @@ impl TimeValLike for TimeSpec { | |||
| } | |||
|
|
|||
| impl TimeSpec { | |||
| /// Makes a new `TimeSpec` with the special UTIME_NOW constant | |||
| #[inline] | |||
| #[cfg(target_os = "linux")] | |||
There was a problem hiding this comment.
Plenty of OSes besides Linux have UTIME_NOW and UTIME_OMIT. Can you please enable all of them here? You may need to make a PR to libc first.
There was a problem hiding this comment.
Yes, I'm happy to do that. I just don't know how to get that exhaustive list of OSes. Any suggestions?
There was a problem hiding this comment.
There's no easy way. All of the open source OSes have online manpages; that's what I use. The hard one is OSX. I haven't found a good, authoritative source for OSX man pages.
There was a problem hiding this comment.
I think you're still leaving out some OS support. FreeBSD, for one, defines these symbols. I haven't checked others. Can you please check their online man pages, and open a PR to libc to add support where it's missing?
There was a problem hiding this comment.
I've got a PR open here: rust-lang/libc#1474
From the documentation: ``` If the tv_nsec field of one of the timespec structures has the special value UTIME_NOW, then the corresponding file timestamp is set to the current time. If the tv_nsec field of one of the timespec structures has the special value UTIME_OMIT, then the corresponding file timestamp is left unchanged. In both of these cases, the value of the corresponding tv_sec field is ignored. ``` Given the current API, there is no way to set tv_nsec to UTIME_NOW, since TimeSpec::nanoseconds mangles the value.
| target_env = "uclibc", | ||
| target_env = "wasi", | ||
| target_os = "android", | ||
| target_os = "emscripten", |
There was a problem hiding this comment.
You can add Dragonfly. Besides that, what targets are missing from this list? Does it not cover everything?
There was a problem hiding this comment.
Opened another PR: rust-lang/libc#1487
|
Hi @lpetre, I just noticed that I created a duplicate PR of this one, since you come first, I would like to merge this and close mine, would you like to rebase your branch and finish this? |
|
Alright, I just realized that you have deleted your Nix fork, then I will close this PR and do it in 1897, thanks for your interest in contributing to Nix! |
From the documentation:
Given the current API, there is no way to set tv_nsec to UTIME_NOW, since TimeSpec::nanoseconds mangles the value.