Clippy cleanup #1107
Merged
Clippy cleanup #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was leftover from internal churn during PR nix-rust#1020.
|
bors r+ |
Build failed |
|
The build failure was caused by four failures to download japaric/cross. bors retry |
Build succeeded
|
cemeyer
reviewed
Sep 7, 2021
| - `Ipv4Addr::octets`, `Ipv4Addr::to_std`, `Error::as_errno`, | ||
| `ForkResult::is_child`, `ForkResult::is_parent`, `Gid::as_raw`, | ||
| `Uid::is_root`, `Uid::as_raw`, `Pid::as_raw`, and `PollFd::revents` now take | ||
| `self` by value. |
There was a problem hiding this comment.
What's the motivation for taking self by value? Doesn't that either consume the original value or require Copy? This change was part of the "Clippy cleanup" commit, which doesn't provide any other context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparation for several changes relating to raising the MSRV, most importantly eliminating
mem::uninitialized.